Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openssh-client #117

Merged
merged 1 commit into from
May 28, 2021
Merged

Add openssh-client #117

merged 1 commit into from
May 28, 2021

Conversation

webbertakken
Copy link
Member

@webbertakken webbertakken commented May 27, 2021

Changes

image

Adds 7 megs

image

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Check if machine id is indeed unaffected by this change.

@github-actions
Copy link

Cat Gif

@GabLeRoux
Copy link
Member

ivan-hernandez-scopely added a commit to ivan-hernandez-scopely/unity-test-runner that referenced this pull request May 28, 2021
ivan-hernandez-scopely added a commit to ivan-hernandez-scopely/unity-builder that referenced this pull request May 28, 2021
@frostebite
Copy link
Member

Hi, nice work, LGTM!

@webbertakken
Copy link
Member Author

https://github.com/game-ci/docker/pull/117/checks?check_run_id=2687062562 👀

I consider the 1 failure an anomaly. Especially considering the change.

@webbertakken webbertakken merged commit 11297cf into main May 28, 2021
@webbertakken webbertakken deleted the add-open-ssh-client branch May 28, 2021 17:43
webbertakken pushed a commit to game-ci/unity-builder that referenced this pull request May 28, 2021
…256)

* using SSH_AUTH_SOCK (ssh agent forwarding) to pull upm private repos

* sshAgent as input parameter

* yarn run prettier --write "src/**/*.{js,ts}"

* yarn run lint --fix && yarn build

* fixed compilation after rebase

* removed RUN apt-get update && apt-get install -y openssh-client. This change needs to be done upstream. See game-ci/docker#117
webbertakken pushed a commit to game-ci/unity-test-runner that referenced this pull request May 28, 2021
…124)

* using SSH_AUTH_SOCK (ssh agent forwarding) to pull upm private repos

* sshAgent as input parameter

* yarn run prettier --write "src/**/*.{js,ts}"

* yarn run lint --fix && yarn build

* reverted results-meta.ts (changed because ran prettier --check "src/**/*.js" without && eslint src)

* removed RUN apt-get update && apt-get install -y openssh-client. This change needs to be done upstream. See game-ci/docker#117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants